Merged
Conversation
adding details about invalid GC string
tukib
reviewed
Dec 17, 2024
Member
tukib
left a comment
tukib
left a comment
There was a problem hiding this comment.
Thanks for the contribution @slimerunner! I've added a couple suggestions to take a look at, but otherwise this looks good to me
Co-authored-by: Bryn Ward-Leikis <ward.leikis@gmail.com>
matr1x-hackmud
approved these changes
Dec 22, 2024
Member
|
Looks good to me. If you're cool with these modifications @slimerunner I'll get this merged in for you 👍 Alternatively, after a few days I'll merge it regardless (or you can press the green button yourself). Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding details about invalid GC string
Problem
Context