Merged
Conversation
Member
|
We merged #498 Update your branch to get the test CI passing |
Contributor
Author
|
|
Member
|
apparently wasn't enough. We got this one merged: #499 try an update again this time and let's see if the tests pass / run correctly now. :) |
tukib
reviewed
Dec 5, 2024
Member
tukib
left a comment
tukib
left a comment
There was a problem hiding this comment.
This is great! I've added some suggestions, and you will need to rename the filename to return_object.mdx for it to be registered as wiki page.
Co-authored-by: Bryn Ward-Leikis <ward.leikis@gmail.com>
Co-authored-by: Bryn Ward-Leikis <ward.leikis@gmail.com>
Co-authored-by: Bryn Ward-Leikis <ward.leikis@gmail.com>
tukib
approved these changes
Dec 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All over the wiki, "success" and "failure" objects are referenced, but it is not ever explained what they actually are. You can sort of piece it together by checking the
.ok()page under scripts.lib, but instead I figured it would make more sense to just actually have a page that explained what it was and how it worked.I've not created a page before, so the formatting is just based off what I observed from some of the other pages. As well, all the links on the wiki seem to be broken right now, so I'm not entirely sure if the link to the
okandnot_implpages have been formatted correctly, but I'm reasonably confident.