Auto-update dependencies: output info in machine-readable format #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodersky
force-pushed
the
serialize-dependencies
branch
from
856d62b to
2215d22
Compare
jodersky
changed the title
jodersky
changed the title
jodersky
changed the title
lefou
reviewed
Jan 26, 2020
scalalib/src/dependency/versions/ModuleDependenciesVersions.scala
Outdated
Show resolved
Hide resolved
This avoids exposing non-serializable data structures.
This makes it easy to build other tasks that depend on the output of dependency updates
jodersky
force-pushed
the
serialize-dependencies
branch
from
2215d22 to
8e6bf2d
Compare
|
@lefou, I addressed your comments |
lefou
reviewed
Feb 15, 2020
| @@ -18,6 +18,10 @@ object Dependency extends ExternalModule { | |||
| allowPreRelease) | |||
| } | |||
|
|
|||
| def showUpdates(ev: Evaluator, allowPreRelease: Boolean = false) = T.command{ | |||
There was a problem hiding this comment.
Can you please add some ScalaDoc to the new command. It would be great, if you could also update/add the comment of the changed updates command.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mill has a convenient task to check for the availability of newer versions of dependencies
mill.scalalib.Dependency/updates.Unfortunately this task only prints the output (in human readable form), but does not persist it in a machine-readable format. This makes it very difficult to reuse the output in other tasks, essentially requiring regex parsing of strings.
The changes proposed here change the
updatestask to expose the underlying data structures representing the upgrade path. An additional task,showUpdatesis added, implementing the original, human readable, output of updates.