Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #4521

Merged
merged 20 commits into from
Feb 10, 2025
Merged

Cleanup #4521

merged 20 commits into from
Feb 10, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Feb 10, 2025

  • Privatize everything possible in core.{internal,exec,resolve}
  • Rename mill.main.client to mill.client
  • Remove duplication from mill.{api,util}.Util, break out a private[mill] mill.util.MillModuleUtil
  • Split up mill.client.Util to have a separate mill.client.ClientUtil with Util containing user-facing stuff and ClientUtil containing internal stuff (though it can't be private since java doesn't support private[mill]
  • Add basic Scaladoc to the various modules in core/ to try and define what each one is meant to do

@lihaoyi lihaoyi changed the title Privatize everything in core.{internal,exec,resolve} Privatize everything in core.{internal,exec,resolve}, remove duplication from mill.{api,util}.Util Feb 10, 2025
@lihaoyi lihaoyi changed the title Privatize everything in core.{internal,exec,resolve}, remove duplication from mill.{api,util}.Util Privatize everything in core.{internal,exec,resolve}, remove duplication from mill.{api,util}.Util, rename mill.main.client to mill.client Feb 10, 2025
@lihaoyi lihaoyi changed the title Privatize everything in core.{internal,exec,resolve}, remove duplication from mill.{api,util}.Util, rename mill.main.client to mill.client Cleanup Feb 10, 2025
@lihaoyi lihaoyi marked this pull request as ready for review February 10, 2025 04:16
@lihaoyi lihaoyi merged commit 147e0f1 into com-lihaoyi:main Feb 10, 2025
29 of 31 checks passed
@lefou lefou added this to the 0.13.0 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants