Move task override tracking from planning time to instantiation time #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b930e1c.
lihaoyi
force-pushed
the
override-tracking
branch
from
292df4e to
2440acd
Compare
lihaoyi
force-pushed
the
override-tracking
branch
from
87742c7 to
351832d
Compare
lefou
reviewed
Feb 4, 2025
| @@ -17,6 +18,8 @@ object BuildInfoTests extends TestSuite { | |||
| def scalaVersion = scalaVersionString | |||
| def buildInfoPackageName = "foo" | |||
| def buildInfoMembers = Seq.empty[BuildInfo.Value] | |||
|
|
|||
| def millDiscover = Discover[this.type] | |||
There was a problem hiding this comment.
Shouldn't this be a val or lazy val, here and in all the other places? The object is already at the end of the inheritance hierarchy, and the def may cause wasteful re-initialisation of Discover.
There was a problem hiding this comment.
Probably can be a lazy val
lihaoyi
force-pushed
the
override-tracking
branch
from
0804abc to
82fe0ef
Compare
lihaoyi
added a commit
that referenced
this pull request
Feb 5, 2025
Since #4181 landed, we no longer need to track `Terminal.Labelled#segments` separately and can just use `Terminal.Labelled#task#ctx#segments#render`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4176
Discovermandatory, even in tests, so it always has useful dataimplicitMillDiscoverthroughout the module hierarchy implicitly throughCtxDiscover#classInfo#declaredTasks#nametogether with the linearization of the Scala trait hierarchy for each module, to decide whether or not a specific task is overridden or notoptionalOverridethat fails onmainand passes on this PRAlso took the opportunity to break up
TestGraphs,EvaluationTestsandResolveTestsa bit. Still pretty messy, but better than before