-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups in Java docs and user experience #3278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
Move
Cleanups in Java docs and user experience
Jul 20, 2024
TestModule.*
dependencies to mandatoryIvyDeps
lefou
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making all the test trait names consistent is a good idea!
How about deprecating the other names, so we can remove them in 0.13
?
lolgab
reviewed
Jul 22, 2024
lolgab
reviewed
Jul 22, 2024
lolgab
reviewed
Jul 22, 2024
lolgab
reviewed
Jul 22, 2024
lefou
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MoveHit some issues with bincompat and supers, skipping this for nowTestModule.*
dependencies tomandatoryIvyDeps
. This better fits what they are, sincemandatoryIvyDeps
is defined as Mandatory ivy dependencies that are typically always required and shouldn't be removed by overridingAlias
JavaModuleTests
toJavaTests
(ditto forMavenModuleTests
,SbtModuleTests
, etc.) for consistency withScalaTests
Specialize Intro to Mill for Java/Scala pages for each respective audience
Pull request: #3278