Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups in Java docs and user experience #3278

Merged
merged 17 commits into from
Jul 22, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 20, 2024

  • Move TestModule.* dependencies to mandatoryIvyDeps. This better fits what they are, since mandatoryIvyDeps is defined as Mandatory ivy dependencies that are typically always required and shouldn't be removed by overriding Hit some issues with bincompat and supers, skipping this for now

  • Alias JavaModuleTests to JavaTests (ditto for MavenModuleTests, SbtModuleTests, etc.) for consistency with ScalaTests

  • Specialize Intro to Mill for Java/Scala pages for each respective audience

Pull request: #3278

@lihaoyi lihaoyi changed the title Move TestModule.* dependencies to mandatoryIvyDeps Cleanups in Java docs and user experience Jul 20, 2024
@lihaoyi lihaoyi requested review from lefou and lolgab July 21, 2024 06:01
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making all the test trait names consistent is a good idea!

How about deprecating the other names, so we can remove them in 0.13?

.config/mill-version Outdated Show resolved Hide resolved
@lihaoyi lihaoyi merged commit ed89310 into com-lihaoyi:main Jul 22, 2024
39 checks passed
@lefou lefou added this to the 0.11.10 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants