BSP: Handle new JvmCompileClasspath request
#3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client report to support the `JvmCompileClasspathReceiver` capability, we also return an empty classpath from the `ScalacOptions` request. Update bsp4j from 2.2.0-M1 to 2.2.0-M2
lefou
changed the title
JvmCompileClasspath requestJvmCompileClasspath request
kasiaMarek
added a commit
to kasiaMarek/metals
that referenced
this pull request
Jun 26, 2024
kasiaMarek
added a commit
to kasiaMarek/metals
that referenced
this pull request
Jun 27, 2024
kasiaMarek
added a commit
to scalameta/metals
that referenced
this pull request
Jun 28, 2024
* improvement: add debug adapter for running main class to metals * add tests * wee cleanup * clean up * fix: use javacOptions classpath if scalacOptions are empty connected to: com-lihaoyi/mill#3086 * add more informative errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the new
JmvCompileClasspathrequest as part of the JVM extension.If the client reports to support the
JvmCompileClasspathReceivercapability,we also return an empty classpath from the
ScalacOptionsrequest.Update bsp4j from 2.2.0-M1 to 2.2.0-M2
See: