Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demosaicing does not return clipped values #3

Closed
timmeinhardt opened this issue Dec 5, 2016 · 3 comments
Closed

Demosaicing does not return clipped values #3

timmeinhardt opened this issue Dec 5, 2016 · 3 comments

Comments

@timmeinhardt
Copy link

Demosaicing a normalized bayer image with float values between 0 and 1 using the demosaicing_CFA_Bayer_Malvar2004 method does not return a clipped image. This should either be mentioned in the documentation or demosaicing methods should finish with an appropriate clipping step since without noticing this behaviour the resulting PSNRs are significantly worse.

@KelSolaar
Copy link
Member

That is a good point, at the moment none of the demosaicing definitions are clipping return values which is kind of consistent with everything we do for Colour or any related projects like this one.

The benefit in that particular case is that it allows for demosaicing HDR images: you merge the CFA bayer sensor data and then perform demosaicing as this Jupyter Notebook showcases it. If you were to clip the demosaiced output you would obviously lose all the dynamic range.

That being said I'll make a note in the definition.

Cheers,

Thomas

@timmeinhardt
Copy link
Author

I did not know about the HDR application wich makes perfectly sense. A note in the documentation is totally fine then. This can be closed. Thanks for your fast response!

@KelSolaar
Copy link
Member

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants