[multiplyMatrices] Update implementation to pass all tests #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates implementation and passes all tests for
multiplyMatrices
.I attempted to make the smallest changes per commit to pass skipped tests. Once a test was passed, I didn't skip it again (resulting in one regression that was also fixed).
Note: To see that an error is no longer thrown by multiplying empty arrays, you'll have to comment out the
block in the Incorrect Data test when running
htest
.@lloydk, let me know how this looks to you. And I can also fit some refactoring into this pull request before it's merged, if needed.
I wanted to prioritize minimal changes to pass the tests which would make a future refactor easier to understand before I started it.