Skip to content

feat: support non-parent interleaves #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

taka-oyama
Copy link
Collaborator

@taka-oyama taka-oyama commented Apr 28, 2025

@taka-oyama taka-oyama added the enhancement New feature or request label Apr 28, 2025
@taka-oyama taka-oyama requested a review from a team April 28, 2025 04:39
@taka-oyama taka-oyama self-assigned this Apr 28, 2025
Copy link

coderabbitai bot commented Apr 28, 2025

Walkthrough

The changes introduce a new method, interleaveIn, in the Blueprint class to generalize the logic for interleaving tables, allowing specification of whether the interleave is in a parent table via a boolean parameter. The existing interleaveInParent method is refactored to delegate to this new method. The grammar logic for generating SQL interleave clauses is updated to utilize the new inParent property and build the clause string conditionally. The InterleaveDefinition class PHPDoc is updated to include the inParent property annotation. Additional tests are added to verify the behavior of the new interleaveIn method and its SQL generation.

Changes

Files/Paths Change Summary
src/Schema/Blueprint.php Added interleaveIn method; refactored interleaveInParent to call interleaveIn with $parent = true. Consolidated interleaving logic.
src/Schema/Grammar.php Modified addInterleaveToTable to use the new inParent property and adjust SQL clause construction accordingly.
src/Schema/InterleaveDefinition.php Updated PHPDoc to add @property bool $inParent annotation.
tests/Schema/BlueprintTest.php Added a new test block to test_interleaving to cover the new interleaveIn method and verify SQL output.

Suggested labels

waiting for review

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c09b48d and 8f4ec5a.

📒 Files selected for processing (2)
  • src/Schema/Blueprint.php (1 hunks)
  • src/Schema/Grammar.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/Schema/Grammar.php
  • src/Schema/Blueprint.php
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Run-PHPUnit
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taka-oyama taka-oyama marked this pull request as ready for review May 21, 2025 07:01
@taka-oyama taka-oyama requested a review from halnique May 23, 2025 05:23
@taka-oyama taka-oyama requested a review from a team May 26, 2025 07:53
@taka-oyama taka-oyama merged commit df9d0a4 into master May 29, 2025
1 check passed
@taka-oyama taka-oyama deleted the feature/non-parent-interleave branch May 29, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants