Skip to content

feat: implement actual app restart and update word choice#143

Merged
zeriyoshi merged 4 commits intomainfrom
word_choice
Apr 2, 2026
Merged

feat: implement actual app restart and update word choice#143
zeriyoshi merged 4 commits intomainfrom
word_choice

Conversation

@zeriyoshi
Copy link
Copy Markdown
Collaborator

@zeriyoshi zeriyoshi commented Apr 2, 2026

  • コメントを確認し、実装計画を立てる
  • app/electron/main.tsrestart-app IPC ハンドラーを追加(app.relaunch() + app.exit(0)
  • app/electron/preload.tsrestartApp API を追加
  • app/electron/global.d.ts に型定義を追加
  • app/shared/types/external.d.ts に共有型定義を追加
  • app/electron/app/ElectronApp.tsx: Electron 再起動時に localStorage を使用し、起動時に両方をチェック・クリア
  • app/shared/core/advancedSettingsModal.ts: Electron では localStorage + restartApp()、Chrome では sessionStorage + reload()
  • app/shared/i18n/lang/enUS.ts: 英語翻訳を "reload" → "restart" に変更
  • コードレビューと最終確認(セキュリティアラートなし)

Copilot AI review requested due to automatic review settings April 2, 2026 05:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Japanese (ja-JP) UI wording to replace “再読み込み” with “再起動” in settings-related confirmation/alert messages.

Changes:

  • Updated settingsMenu.resetSuccess message wording to say the application will “restart”.
  • Updated settingsModal.alerts.reloadRequired* messages to say a “restart” is required.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

devin-ai-integration[bot]

This comment was marked as resolved.

Copilot AI changed the title chore: change word choice feat: implement actual app restart and update word choice Apr 2, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@zeriyoshi
Copy link
Copy Markdown
Collaborator Author

@copilot

sessionStorageのデータがapp.relaunch()で失われ、再起動後の更新チェックが実行されない

Devin が指摘したこの不具合を修正してください。また、英語翻訳 enUS.ts も日本語の文面の変更に合わせて変更にしてください

devin-ai-integration[bot]

This comment was marked as resolved.

…s translations

Agent-Logs-Url: https://github.com/colopl/colopresso/sessions/a39e184c-5c8f-46db-8363-0fcf33fda818

Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

@copilot

sessionStorageのデータがapp.relaunch()で失われ、再起動後の更新チェックが実行されない

...

a742841 で対応しました。

sessionStorage の問題修正:

  • Electron で restartApp() を呼ぶ前に localStorage にフラグを保存するよう変更(sessionStorage はプロセス終了で失われるため)
  • 起動時の useEffectsessionStoragelocalStorage の両方をチェックし、どちらも確実にクリアするよう変更
  • advancedSettingsModal.ts でも同様に、Electron では localStorage、Chrome では sessionStorage を使い分けるよう修正

英語翻訳の更新:

  • settingsMenu.resetSuccess: "Reloading" → "Restarting"
  • settingsModal.alerts.reloadRequired: "reloading/reload" → "restarting/restart"
  • settingsModal.alerts.reloadRequiredTitle: "Reload Required" → "Restart Required"
  • settingsModal.alerts.reloadRequiredWarning: "reload" → "restart"

@zeriyoshi zeriyoshi merged commit 907bba6 into main Apr 2, 2026
17 checks passed
@zeriyoshi zeriyoshi deleted the word_choice branch April 2, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants