Used pkg-config to link protobuf and GLFW3, and add support for distros using external fmt
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the right way to link `protobuf`, and fixes the issue in Arch and Void.
blacklightpy
changed the title
pkg-config to link protobufpkg-config to link protobuf and GLFW3, and add support for distros using external fmt
Contributor
Author
|
Contributor
Author
|
Tested build on Void (musl libc edition). |
collinalexbell
approved these changes
Nov 19, 2024
Owner
collinalexbell
left a comment
collinalexbell
left a comment
There was a problem hiding this comment.
Thank you for the greatly improved makefile and for teaching me pkg-config & --as-needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the right way to link
protobuf, and fixes the issue in Arch and Void in #48.