Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1399 - skip expanding through fields on clone #1407

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

collerek
Copy link
Owner

@collerek collerek commented Dec 4, 2024

No description provided.

Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #1407 will improve performances by 44.71%

Comparing skip-expanding-through-fields-on-clone (ff458c6) with master (1cd9204)

Summary

⚡ 3 improvements
✅ 81 untouched benchmarks

Benchmarks breakdown

Benchmark master skip-expanding-through-fields-on-clone Change
test_count[1000] 5.9 ms 5.2 ms +12.52%
test_first[1000] 4.1 ms 2.8 ms +44.71%
test_get_one[500] 3.1 ms 2.6 ms +20.88%

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1cd9204) to head (ff458c6).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       207    +1     
  Lines        14940     14960   +20     
=========================================
+ Hits         14940     14960   +20     
Files with missing lines Coverage Δ
ormar/models/helpers/relations.py 100.00% <100.00%> (ø)
...tion/test_through_model_relation_setup_on_clone.py 100.00% <100.00%> (ø)

@collerek collerek merged commit ca55e9c into master Dec 4, 2024
20 checks passed
@collerek collerek deleted the skip-expanding-through-fields-on-clone branch December 4, 2024 14:45
@collerek collerek mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant