Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy translate_list_to_dict default argument #1382

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

cadlagtrader
Copy link
Contributor

@cadlagtrader cadlagtrader commented Jul 13, 2024

Fixes #1381

@cadlagtrader cadlagtrader force-pushed the fix_listtodict_default branch from e3c70df to ecd50e3 Compare July 13, 2024 19:14
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca55e9c) to head (50dda41).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        14960     14969    +9     
=========================================
+ Hits         14960     14969    +9     
Files with missing lines Coverage Δ
ormar/queryset/utils.py 100.00% <100.00%> (ø)
tests/test_utils/test_queryset_utils.py 100.00% <100.00%> (ø)

Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #1382 will degrade performances by 24.67%

Comparing cadlagtrader:fix_listtodict_default (50dda41) with master (ca55e9c)

Summary

❌ 1 (👁 1) regressions
✅ 83 untouched benchmarks

Benchmarks breakdown

Benchmark master cadlagtrader:fix_listtodict_default Change
👁 test_min[250] 2.7 ms 3.6 ms -24.67%

@collerek collerek merged commit aa82051 into collerek:master Dec 4, 2024
13 checks passed
@collerek
Copy link
Owner

collerek commented Dec 4, 2024

Thanks a lot! :)

@collerek collerek mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random error when prefetching models
2 participants