Streamline the java StringToTime code#2
Open
jtnelson wants to merge 5 commits intocollegeman:masterfrom
Open
Conversation
Change-Id: Ia5a04830b15ca0d57e746cd20723ee9a214ccbe6
Change-Id: I96d2dff9864e0de538711176b12c61ffa8061b1a
…tatic factories that return joda or long timestamp Change-Id: I88908e2ef377dd16ce3a28677b7ded353856b2ff
There is really no need for StringToTime to be used as an object instance, especially since java Date is inferior to Joda DateTime. Therefore, I've altered the class to preserve the parsing logic that the original author wrote, but to function as a static util class and either return a timestamp or a joda DateTime object. This greatly simplifies the class. Right now, the parsing still uses java Date under the hood, but that may be changed in a future commit Change-Id: Ice0dc3287117b0017dfea7c6b18b4850f048cdf1
Change-Id: Ie8def9f5b20b32df33c5447308784d2232c8a180
Owner
|
Thanks for your effort! I haven't used this code in years. I haven't Aaron Collegeman On Sun, Nov 10, 2013 at 12:04 PM, Jeff Nelson notifications@github.comwrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlined the code to function more as a static utility class and be compatible with Joda DateTime.