Ignore future jobs in jobs:check.#1159
Open
joshuapinter wants to merge 2 commits into
Open
Conversation
albus522
reviewed
Sep 28, 2022
… jobs:check. If a job is currently being processed, we want an option to exclude them from being reported in `jobs:check`. `jobs:check`’s primary purpose should be to see the outstanding queue, not determining long-running jobs. Made this option default to false so no breaking changes but simply pass true for `not_locked` to exclude them from this check. Remove extra `AND`.
If there are scheduled jobs in the future, they should not be included in the jobs:check, which is intended to look for jobs that should be processed but have not yet been processed. To accomplish this we check if the `run_at` is before the `max_age` (default: 300 seconds) instead of the `created_at`.
Author
|
@albus522 Change made to only query against Let me know if you need any other changes to get this merged in. And thanks for the feedback and patience! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore future jobs in
jobs:check.If there are scheduled jobs in the future, they should not be included in the jobs:check, which is intended to look for jobs that should be processed but have not yet been processed.
To accomplish this we check if the
run_atis before themax_age(default: 300 seconds) instead of thecreated_at.