Merge pull request #751 from natashamm/issue_698

Improve coverage in 5 spots

src/icalendar/cli.py

@@ -28,9 +28,9 @@ def _format_attendees(attendees):
 
     :returns str: Formatted list of attendees.
     """
-    if isinstance(attendees, list):
-        return '\n'.join(map(lambda s: s.rjust(len(s) + 5), map(_format_name, attendees)))
-    return _format_name(attendees)
+    if isinstance(attendees, str):
+        attendees = [attendees]
+    return '\n'.join(map(lambda s: s.rjust(len(s) + 5), map(_format_name, attendees)))
 
 def view(event):
     """Make a human readable summary of an iCalendar file.

src/icalendar/prop.py

@@ -450,7 +450,7 @@ def __init__(self, dt):
             self.params = Parameters({'value': 'DATE'})
         elif isinstance(dt, time):
             self.params = Parameters({'value': 'TIME'})
-        elif isinstance(dt, tuple):
+        else: # isinstance(dt, tuple)
             self.params = Parameters({'value': 'PERIOD'})
 
         tzid = tzid_from_dt(dt) if isinstance(dt, (datetime, time)) else None

src/icalendar/tests/test_cli_tool.py

@@ -26,7 +26,6 @@
 BEGIN:VEVENT
 ORGANIZER:organizer@test.test
 ATTENDEE:attendee1@example.com
-ATTENDEE:attendee2@test.test
 SUMMARY:Test summary
 DTSTART;TZID=Europe/Warsaw:20220820T200000
 DTEND;TZID=Europe/Warsaw:20220820T203000
@@ -74,7 +73,6 @@ def local_datetime(dt):
     Organizer: organizer <organizer@test.test>
     Attendees:
      attendee1 <attendee1@example.com>
-     attendee2 <attendee2@test.test>
     Summary    : Test summary
     Starts     : {secondstart}
     End        : {secondend}

src/icalendar/tests/test_period.py

@@ -9,7 +9,7 @@
 
 import pytest
 
-from icalendar.prop import vDDDTypes
+from icalendar.prop import vDDDTypes, vPeriod
 
 
 @pytest.mark.parametrize(
@@ -95,3 +95,18 @@ def test_tzid_is_part_of_the_period_values(calendars, tzp):
         datetime.datetime(2023, 12, 13, 12), "America/Vancouver"
     )
     assert end == tzp.localize(datetime.datetime(2023, 12, 13, 15), "America/Vancouver")
+
+
+def test_period_overlaps():
+    # 30 minute increments
+    datetime_1 = datetime.datetime(2024, 11, 20, 12, 0)  # 12:00
+    datetime_2 = datetime.datetime(2024, 11, 20, 12, 30) # 12:30
+    datetime_3 = datetime.datetime(2024, 11, 20, 13, 0)  # 13:00
+
+    period_1 = vPeriod((datetime_1,datetime_2))
+    period_2 = vPeriod((datetime_1,datetime_3))
+    period_3 = vPeriod((datetime_2,datetime_3))
+
+    assert period_1.overlaps(period_2)
+    assert period_3.overlaps(period_2)
+    assert not period_1.overlaps(period_3)

src/icalendar/tests/test_unit_caselessdict.py

@@ -104,6 +104,8 @@ def test_CaselessDict(self):
         self.assertEqual(ncd["key1"], "val1")
         self.assertEqual(ncd["KEY1"], "val1")
 
+        assert ncd.has_key("key1")
+
         ncd["KEY3"] = "val3"
         self.assertEqual(ncd["key3"], "val3")
 

src/icalendar/tests/test_unit_parser_tools.py

@@ -1,6 +1,6 @@
 import unittest
 
-from icalendar.parser_tools import data_encode, to_unicode
+from icalendar.parser_tools import data_encode, to_unicode, from_unicode
 
 
 class TestParserTools(unittest.TestCase):
@@ -14,6 +14,9 @@ def test_parser_tools_to_unicode(self):
         self.assertEqual(to_unicode(1), 1)
         self.assertEqual(to_unicode(None), None)
 
+    def test_parser_tools_from_unicode(self):
+        self.assertEqual(from_unicode("\u01b5", encoding="ascii"), b"\xc6\xb5")
+
     def test_parser_tools_data_encode(self):
         data1 = {
             "k1": "v1",