feat: clean up Dockerfile and reduce image size #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikajdan
commented
Sep 21, 2025
ikajdan
commented
- Replace ADD with COPY to avoid unnecessary behaviors
- Install packages with --no-install-recommends to keep images slim
- Clean up apt lists to reduce image size
- Simplify user creation (fixes Runner user creation fails in Docker image #105)
- Replace ADD with COPY to avoid unnecessary behaviors - Install packages with --no-install-recommends to keep images slim - Clean up apt lists to reduce image size - Simplify user creation and drop redundant ARG
Author
|
Hi @sjoerdsimons, any chance someone could take a look this? Since it hasn't seen activity for a while. |
Contributor
|
Please split things up in multiple commits and document your commits better e.g. |
| COPY . . | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends pkg-config libssl-dev cmake && \ |
Contributor
There was a problem hiding this comment.
please don't spuriously change layout/indentation in a commit with actual changes, it makes things ahrder to review
| apt-get install -y --no-install-recommends libssl3 ca-certificates && \ | ||
| rm -rf /var/lib/apt/lists/* && \ | ||
| groupadd -g 1001 lava-gitlab-runner && \ | ||
| useradd -u 1001 -g lava-gitlab-runner -d /app -M lava-gitlab-runner |
Contributor
There was a problem hiding this comment.
Keep one logical change per RUN actions ; adduser and installing libssl are two very orthogonal things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.