ask again for device permissions in Firefox when user cleared them ma…

…nually (#468)
collab-project · May 19, 2020 · 4d2de73 · 4d2de73
1 parent 6779cf0
commit 4d2de73
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,8 @@
   `exportImage` (#417)
 - Fix file extension for `video/x-matroska` mime-type (#464, #469)
 - Fix milliseconds in `formatTime` (#443)
+- Ask again for device permissions in Firefox when user cleared them
+  manually (#468)
 - Move documentation to website (#472)
 - Bump required version for:
   - video.js (7.0.5 or newer)

diff --git a/src/js/videojs.record.js b/src/js/videojs.record.js
@@ -472,7 +472,7 @@ class Record extends Plugin {
                         }
                     };
                 }
-                // open browser device selection dialog
+                // open browser device selection/permissions dialog
                 this.surfer.surfer.microphone.start();
                 break;
 
@@ -811,6 +811,12 @@ class Record extends Plugin {
      */
     start() {
         if (!this.isProcessing()) {
+            // check if user didn't revoke permissions after a previous recording
+            if (this.stream && this.stream.active === false) {
+                // ask for permissions again
+                this.getDevice();
+                return;
+            }
             this._recording = true;
 
             // hide play/pause control