-
-
Notifications
You must be signed in to change notification settings - Fork 17
Refactored: works for multiple password inputs, fixes regarding autofill… #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
slackero
wants to merge
12
commits into
coliff:main
Choose a base branch
from
slackero:fix-and-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b4a429b
Refactored, release v1.3.0
slackero f974e4d
Fixes problems with autofill
slackero dd9cb61
Added aria-pressed attribute to button
slackero c1a6b0c
Updated REDAME and fixed demos
slackero 9bdefb4
Updated package.json
slackero f98d247
Text changes
slackero 6e1bdd9
Release v1.3.1, use scoped package name
slackero edd2314
Fixes npm version image
slackero 46684e0
Added script working with jQuery or Cash
slackero d27a29d
Merge branch 'main' into fix-and-feature
slackero a4d4476
Added type button, avoid submit on password toggle
slackero 9ededde
Text changes
slackero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ Thumbs.db | |
|
||
# Files | ||
package-lock.json | ||
npm-debug.log | ||
npm-debug.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
## Changes | ||
|
||
### [1.3.3] - 2021-11-06 | ||
- Fixes problem with the toggle button by adding the attribute `type="button"` to the jQuery version of the script. | ||
|
||
### [1.3.2] - 2021-11-06 | ||
- Added script working with jQuery or Cash. | ||
|
||
### [1.3.1] - 2021-10-31 | ||
- Fixes the problem that autofill hides the toggle icon. | ||
- Added the `aria-pressed` attribute. | ||
- Updated the demos ([Bootstrap 4](https://coliff.github.io/bootstrap-show-password-toggle/tests/bootstrap4-sign-in/), [Bootstrap 5](https://coliff.github.io/bootstrap-show-password-toggle/tests/bootstrap5-sign-in/)) | ||
|
||
### [1.3.0] - 2021-10-30 | ||
- Works with multiple `input[type=password]`. | ||
- The `aria-label` of the toggle button can be customized adding `data-show` and `data-hide` attributes to the password input. | ||
- The toggle button is added by JavaScript, remove existing `<button>` tags. | ||
- The toggle button works more stable. | ||
- The toggle button is always visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.