Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support complex recursive dependency category specification #646

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 20, 2024

When computing the dependency graph, the existing API exposes a parameter for indicating which direct dependency categories to collect as well as what indirect (recursive) dependency categories to collect.

This change allows the caller to specify different recursive dependency categories depending on which category included the dependency in the graph to begin with.

Eventually, this enhancement can be leveraged as part of the "dependency narrowing" effort to drop build-only dependencies from a chain where only runtime dependencies are specified.

When computing the dependency graph, the existing API exposes a
parameter for indicating which direct dependency categories to collect
as well as what indirect (recursive) dependency categories to collect.

This change allows the caller to specify different recursive
dependency categories depending on which category included the
dependency in the graph to begin with.
@cottsay cottsay added the enhancement New feature or request label May 20, 2024
@cottsay cottsay self-assigned this May 20, 2024
@cottsay cottsay marked this pull request as ready for review May 24, 2024 21:20
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.25%. Comparing base (db84706) to head (25e73e7).

Files Patch % Lines
colcon_core/package_descriptor.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   83.23%   83.25%   +0.01%     
==========================================
  Files          66       66              
  Lines        3842     3852      +10     
  Branches      758      762       +4     
==========================================
+ Hits         3198     3207       +9     
  Misses        556      556              
- Partials       88       89       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the Infrastructure meeting today. Thanks very much Scott for talking us through the changes.

@cottsay cottsay merged commit 520052d into master Jun 3, 2024
36 checks passed
@cottsay cottsay deleted the cottsay/recursive-category-chains branch June 3, 2024 19:07
@cottsay cottsay added this to the 0.16.2 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants