Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invocation with no available verbs or env vars #620

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 22, 2024

It might be useful when measuring performance to invoke colcon with an entire class of extensions blocked. This change "handles" the case where no verbs are available and minimizes the output when there are no verbs or environment variables available.

When invoked normally, this change should not modify any existing behavior.

@cottsay cottsay added the enhancement New feature or request label Feb 22, 2024
@cottsay cottsay self-assigned this Feb 22, 2024
@cottsay cottsay marked this pull request as ready for review February 22, 2024 15:57
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (c7d8194) to head (83a5a76).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   83.37%   83.39%   +0.02%     
==========================================
  Files          66       66              
  Lines        3789     3794       +5     
  Branches      737      739       +2     
==========================================
+ Hits         3159     3164       +5     
  Misses        556      556              
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It might be useful when measuring performance to invoke colcon with an
entire class of extensions blocked. This change "handles" the case where
no verbs are available and minimizes the output when there are no verbs
or environment variables available.
@cottsay cottsay merged commit 6cf24ea into master Mar 11, 2024
42 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/no-verbs-env-vars branch March 11, 2024 23:00
@cottsay cottsay added this to the 0.15.3 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant