RUSTSEC-2020-0082: ordered_float:NotNan may contain NaN after panic in assignment operators #1
Description
ordered_float:NotNan may contain NaN after panic in assignment operators
| Details | |
|---|---|
| Package | ordered-float |
| Version | 1.0.2 |
| URL | reem/rust-ordered-float#71 |
| Date | 2020-12-06 |
| Patched versions | >=1.1.1, <2.0.0,>=2.0.1 |
| Unaffected versions | <0.2.2 |
After using an assignment operators such as NotNan::add_assign, NotNan::mul_assign, etc., it was possible for the resulting NotNan value to contain a NaN. This could cause undefined behavior in safe code, because the safe NotNan::cmp method contains internal unsafe code that assumes the value is never NaN. (It could also cause undefined behavior in third-party unsafe code that makes the same assumption, as well as logic errors in safe code.)
This was mitigated starting in version 0.4.0, by panicking if the assigned value is NaN. However, in affected versions from 0.4.0 onward, code that uses the NotNan value during unwinding, or that continues after catching the panic, could still observe the invalid value and trigger undefined behavior.
The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring that the assignment operators panic without modifying the operand, if the result would be NaN.
See advisory page for additional details.