Skip to content
This repository was archived by the owner on Jun 22, 2020. It is now read-only.

Add ionomy exchange #2067

Open
MitchellCash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ionomy exchange #2067

MitchellCash wants to merge 1 commit into from

Conversation

@MitchellCash
Copy link

@MitchellCash MitchellCash commented Apr 26, 2020

  • What is the purpose of this Pull Request?
    Add ionomy exchange.

  • I have added Specs

  • (If implementing Market Ticker) I have verified that the volume refers to BASE

  • (If implementing Market Ticker) I have verified that the base and target is assigned correctly

  • I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.

  • I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)

client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse

@MitchellCash MitchellCash changed the title Add ionomy exchange [WIP] Add ionomy exchange Apr 26, 2020
@MitchellCash
Copy link
Author

MitchellCash commented Apr 26, 2020

Apologies, noticed a small bug in the ionomy API. Will fix and update, please hold off merging until then.

@MitchellCash MitchellCash changed the title [WIP] Add ionomy exchange Add ionomy exchange Apr 29, 2020
@MitchellCash
Copy link
Author

MitchellCash commented Apr 29, 2020

PR updated to reflect latest ionomy API. Ready for review/merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MitchellCash