This repository was archived by the owner on Jun 22, 2020. It is now read-only.
Feat/bamboo relay #1920
Open
Feat/bamboo relay #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update the Bamboo Relay integration, adds gzip support, adds trades service and associated specs.
This also (partially) addresses volume reported - I've added a
realVolumeflag, which will just return the volume for orders that had thefeeRecipientAddressset to Bamboo Relay.Previously this was tracking all filled orders i.e. Radar Relay as well.
In future there will likely be further double-counting though - as the new version of 0x allows for filling orders via Kyber/Eth2Dai/etc, so this is going to end up recorded in more than one place.