initial work to support SignalExternalWorkflow#134
Merged
antstorm merged 18 commits intocoinbase:masterfrom Feb 14, 2022
Merged
initial work to support SignalExternalWorkflow#134antstorm merged 18 commits intocoinbase:masterfrom
antstorm merged 18 commits intocoinbase:masterfrom
Conversation
antstorm
reviewed
Feb 7, 2022
antstorm
reviewed
Feb 11, 2022
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Added a few mire comments, but it's coming together nicely! Great job!👍
antstorm
approved these changes
Feb 14, 2022
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Looks great, thank you very much for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added integration tests. Both success and failure paths are tested and green.
Ready for review and/or merge. If you want more docs on it in the main README, let me know and I'll cook something up.