Skip to content

Bug: Add baseBuilder property in MiniAppManifest type and let it include in withValidManifest #2512

@tawago

Description

@tawago

Describe the bug and the steps to reproduce it

When a builder wants to import a mini app, baseBuilder property is required in the farcaster.json.
Image

In the Quick start repository example (https://docs.base.org/mini-apps/quickstart/create-new-miniapp), adding baseBuilder to minikit.config.ts does not reflect the change because it uses withValidManifest in app/.well-known/farcaster.json/route.ts and the property gets filtered out, as a result, preventing the builde import the miniapp.

import { withValidManifest } from "@coinbase/onchainkit/minikit";
import { minikitConfig } from "../../../minikit.config";

export async function GET() {
  return Response.json(withValidManifest(minikitConfig)); // "baseBuilder"  gets lost
}

What's the expected behavior?

withValidManifest should not filter out baseBuilder

What version of the libraries are you using?

@coinbase/onchainkit@1.0.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions