Add a new asserter client with ignoring rosetta spec validation. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaying-peng
reviewed
Feb 2, 2024
asserter/asserter.go
Outdated
| ignoreRosettaSpecValidation: true, | ||
| } | ||
|
|
||
| asserter.operationStatusMap = map[string]bool{} |
There was a problem hiding this comment.
let's move this to a const list in validation.go
xiaying-peng
reviewed
Feb 2, 2024
asserter/operation_status.go
Outdated
| @@ -0,0 +1,34 @@ | |||
| // Copyright 2020 Coinbase, Inc. | |||
There was a problem hiding this comment.
from what I saw, we have never changed copyright in asserter last 4 years. only those files in types, client, and server directories have been changed every year.
but anyway, I just changed all files which have copyright 2020.
|
Review Error for xiaying-peng @ 2024-02-05 19:56:08 UTC |
xiaying-peng
approved these changes
Feb 5, 2024
|
Review Error for xiaying-peng @ 2024-02-05 19:56:33 UTC |
xiaying-peng
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
in somecases, rosetta spec validation is not helpful, and it causes some operation work, so now we add a new client which can ignore rosetta spec validation.
Solution
Open questions