Guarantee the order of transactions in the block endpoint #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit guarantees the order of transactions in the block endpoint. It does so by creating a map of fetched transactions and using that map to return the transactions in the original order they had in the block. - Added a new struct `FetchedTransaction` to represent fetched transactions - Updated `fetchChannelTransactions` to use the new `FetchedTransaction` struct - Updated `UnsafeTransactions` to use the new `FetchedTransaction` struct and create a map of fetched transactions - Modified the return statement in `UnsafeTransactions` to use the fetched transactions from the map
This commit adds a timeout to the mock server to prevent it from hanging indefinitely. This is mainly to make salus security scans happy.
This commit fixes a memory leak in the client. The client was not reading the response body of the http request when closing the body, which could lead to a memory leak. This commit fixes this by reading the response body and discarding it. This commit makes salus check pass.
|
two generic comments (i will leave them in the PR as well):
|
|
Hi @GeekArthur , I've done rosetta validation (check-data) for two asset and they all passed. Could you help me merge this PR? |
GeekArthur
approved these changes
Aug 23, 2023
|
are the api_xyz.go changes generated by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This commit guarantees the order of transactions in the block endpoint. This can benefit clients in a certain way. For example, some Rosetta client requires transaction kept in order so that they can identify the coinbase (lower-case c) transaction in one block.
Solution
It does so by creating a map of fetched transactions and using that map to return the transactions in the original order they had in the block.
FetchedTransactionto represent fetched transactionsfetchChannelTransactionsto use the newFetchedTransactionstructUnsafeTransactionsto use the newFetchedTransactionstruct and create a map of fetched transactionsUnsafeTransactionsto use the fetched transactions from the mapThis PR also improves some security issues raised by salus check.
Open questions