Revert "Add GETH_HEADERS to be set as a config environment variable (#44)" #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oinbase#44)" This reverts commit 68306c7.
|
Thanks for doing this @akramhussein :) |
shrimalmadhur
approved these changes
Nov 8, 2021
Merged
racbc
added a commit
to racbc/rosetta-ethereum
that referenced
this pull request
Nov 24, 2021
Removed the line on GETH HEADERS due to the change in coinbase#67.
shrimalmadhur
added a commit
that referenced
this pull request
Dec 3, 2021
* Update README file * Update README.md Removed the line on GETH HEADERS due to the change in #67. * Update README.md Implemented shrimalmadhur's edits to line 134. Co-authored-by: Madhur Shrimal <madhur.shrimal@gmail.com> * Update README.md file Added edits requested by reviewer. Co-authored-by: Madhur Shrimal <madhur.shrimal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I originally added this because some hosted node providers were recommending in their docs to use an HTTP header to authenticate. However, the same providers in fact support the normal method via a URL query parameter.
These changes now feel unnecessary and this PR removes it to simplify the codebase.
Solution
git revert <sha>to generate.Open questions