construction/payloads: Transaction input field should be data accordi… #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Note: This PR replaces #47. I deleted the fork and forgot about the link so had to re-instated.
Motivation
When using the endpoint
construction/payloads
theunsigned_transaction
payload is invalid for passing to a signer. Per #46 references it should bedata
when submitting to a signer andinput
is part of the response.Solution
Rename
input
todata
on thetransaction
andtransactionWire
structs.Open questions
None