Skip to content

Conversation

@jazz-cb
Copy link
Contributor

@jazz-cb jazz-cb commented Sep 11, 2024

What changed? Why?

Qualified Impact

rohan-agarwal-coinbase and others added 14 commits September 9, 2024 15:25
This makes it so that the correlation ID from the API Error is
returned in the API Error response. This will help in debugging
issues more easily as we can quickly link together associated
requests.
This runs the `format` script to update all files from our
formatting.
Return correlation ID from API Error
[chore] update openAPI generated client
@cb-heimdall
Copy link

cb-heimdall commented Sep 11, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 looks good!

@cb-heimdall
Copy link

Review Error for rohan-agarwal-coinbase @ 2024-09-11 22:07:13 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

jazz-cb and others added 2 commits September 11, 2024 15:08
add arbitrum mainnet to changelog
@jazz-cb jazz-cb merged commit f9fb973 into master Sep 11, 2024
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

1 similar comment
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

1 similar comment
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants