Support webhook signature header #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb-davidlai
approved these changes
Aug 29, 2024
src/coinbase/webhook.ts
Outdated
Comment on lines
186
to
190
| `event_type: '${this.getEventType()}', event_filter: ${JSON.stringify(this.getEventFilters())}, ` + | ||
| `notification_uri: '${this.getNotificationURI()}', signature_header: '${this.getSignatureHeader()}' }` | ||
| ); |
Contributor
There was a problem hiding this comment.
can we camel case these please
src/tests/webhook_test.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| describe(".getSignatureHeader", () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe(".getSignatureHeader", () => { | |
| describe("#getSignatureHeader", () => { |
please use # for instance methods and . for static methods
| notificationUri: string, | ||
| eventType: WebhookEventType, | ||
| eventFilters: Array<WebhookEventFilter>, | ||
| signatureHeader = "", |
Contributor
There was a problem hiding this comment.
The create args are getting large. Let's consider adding a createWebhookOptions type
Contributor
There was a problem hiding this comment.
Example using createTransfer
coinbase-sdk-nodejs/src/coinbase/types.ts
Line 862 in 8790a49
test # . use option lint fix test fix test added one more test update conflict con con lint fix
chaoyaji-cb
force-pushed
the
webhook-signature
branch
from
63d95d9 to
ae56bd5
Compare
John-peterson-coinbase
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact
testing