[hotfix] Internal Error Message Surfacing #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-stone
reviewed
Aug 29, 2024
Comment on lines
+262
to
263
| * @throws {Error} If the request does not return a transaction hash. | ||
| * @throws {Error} If the request fails. |
Contributor
There was a problem hiding this comment.
Can we collapse these into a singular @throws statement? If the request fails Not returning a transaction hash feels like an implementation detail here.
Can follow-up on this
alex-stone
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
InternalErrorto properly surface the message whenInternalErroris thrownErrorchild classesQualified Impact