-
Notifications
You must be signed in to change notification settings - Fork 85
[bugfix] Use proper atomic units for staking balances #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toString() might need to change as well, perhaps removes the ETH as it is showing the rawNum, currently
StakingBalance { date: '2024-08-14T00:00:00.000Z' address: '0x80000001677f23a227dfed6f61b132d114be83b8ad0aa5f3c5d1d77e6ee0bf5f73b0af750cc34e8f2dae73c21dc36f4a' bondedStake: '32 ETH' unbondedBalance: '5.566622738 ETH' participantType: 'VALIDATOR' }
ProfMoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Approved review 2264155518 from ProfMoo is now dismissed due to new commit. Re-request for approval.
|
got this when testing locally, but I think it is due to backend returning ETH amount |
|
Review Error for marchsu @ 2024-08-27 19:00:37 UTC |
Approved review 2264246724 from marchsu is now dismissed due to new commit. Re-request for approval.
What changed? Why?
This updates the internal parsing of balance objects from whole units to atomic units to match other balance usage.
Qualified Impact
This impacts the way balances are parsed internally and should not break any client usage.