Skip to content

Conversation

@deangalvin-cb
Copy link
Contributor

What changed? Why?

This updates the internal parsing of balance objects from whole units to atomic units to match other balance usage.

Qualified Impact

This impacts the way balances are parsed internally and should not break any client usage.

@cb-heimdall
Copy link

cb-heimdall commented Aug 27, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@marchsu marchsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toString() might need to change as well, perhaps removes the ETH as it is showing the rawNum, currently

StakingBalance { date: '2024-08-14T00:00:00.000Z' address: '0x80000001677f23a227dfed6f61b132d114be83b8ad0aa5f3c5d1d77e6ee0bf5f73b0af750cc34e8f2dae73c21dc36f4a' bondedStake: '32 ETH' unbondedBalance: '5.566622738 ETH' participantType: 'VALIDATOR' } 

ProfMoo
ProfMoo previously approved these changes Aug 27, 2024
Copy link

@ProfMoo ProfMoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cb-heimdall cb-heimdall dismissed ProfMoo’s stale review August 27, 2024 18:33

Approved review 2264155518 from ProfMoo is now dismissed due to new commit. Re-request for approval.

@marchsu
Copy link
Contributor

marchsu commented Aug 27, 2024

got this when testing locally, but I think it is due to backend returning ETH amount

StakingBalance { date: '2024-08-14T00:00:00.000Z' address: '0x80000001677f23a227dfed6f61b132d114be83b8ad0aa5f3c5d1d77e6ee0bf5f73b0af750cc34e8f2dae73c21dc36f4a' bondedStake: '3.2e-17 ETH' unbondedBalance: '5.566622738e-18 ETH' participantType: 'VALIDATOR' }

@cb-heimdall
Copy link

Review Error for marchsu @ 2024-08-27 19:00:37 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

marchsu
marchsu previously approved these changes Aug 27, 2024
@cb-heimdall cb-heimdall dismissed marchsu’s stale review August 27, 2024 19:07

Approved review 2264246724 from marchsu is now dismissed due to new commit. Re-request for approval.

@deangalvin-cb deangalvin-cb merged commit ba4c9e0 into master Aug 27, 2024
@deangalvin-cb deangalvin-cb deleted the bug/fix-staking-balance-units branch August 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants