Skip to content

V0.0.14 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 5, 2024
Merged

V0.0.14 #127

merged 27 commits into from
Aug 5, 2024

Conversation

@erdimaden
Copy link
Contributor

@erdimaden erdimaden commented Aug 5, 2024 •
edited by marcin-cb
Loading

What changed? Why?

V0.0.14

Adds support for:

  • HTTP Retries
  • Developer Custodial Staking
  • Deprecate Unused Transfer Fields

Qualified Impact

Erdi Maden and others added 19 commits July 11, 2024 17:22
Refactoring listWallets method
4f6b8f1
@marcin-cb
Add staking for wallet addresses
0c16527
@marcin-cb
Add test cases for staking on wallet addresses
06785dd
@marcin-cb
Updating comments
a0dc442
@marcin-cb
Corrected broadcasting the transaction index to a variable
89c6674
@marcin-cb
Consolidated common staking balance functions under parent Address cl…
2e77d13 
…ass + test cases additions
@marcin-cb
Fixed getStatus switch statement in StakingOperation class
9c3a290
@marcin-cb
Consolidated validate staking function to address parent class + adde…
25bbfa2 
…d unit tests
@marcin-cb
Refactor staking function names + add test cases
9138764
@marcin-cb
Removed custom staking operation status, added defaults to rewards li…
1379959 
…sting on external address
@marcin-cb
Added mode parameter to staking functions
042e159
@marcin-cb
Checking transaction for empty, consolidate rewards function to Addre…
626dcae 
…ss parent class
@marcin-cb
Remove duplicate staking rewards function
02e995f
@marcin-cb
Remove unused imports
886c8ff
@marcin-cb
Rebasing changes
e402371
@marcin-cb
Adding test case to pass github action
5b996e0
@yuga-cb
Add capabilities file (#123)
fe0392f 
* Add capabilities file

* Fix row

* Fix first row.
@erdimaden
Merge pull request #98 from coinbase/feat/refactoring-list-wallets
6e8cc9d 
Refactoring listWallets method
@marcin-cb
Merge pull request #122 from coinbase/marcin/staking-developer-custody
0fd04e6 
Add staking and rewards for wallet addresses
@cb-heimdall
Copy link

cb-heimdall commented Aug 5, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link

cb-heimdall commented Aug 5, 2024

Review Error for marcin-cb @ 2024-08-05 22:18:34 UTC
User cannot review their own commit

@marcin-cb marcin-cb requested a review from drohit-cb August 5, 2024 22:29
@marcin-cb marcin-cb merged commit 78aea4d into master Aug 5, 2024
@marcin-cb marcin-cb deleted the v0.0.14 branch August 5, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drohit-cb drohit-cb drohit-cb approved these changes

@marcin-cb marcin-cb marcin-cb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erdimaden @cb-heimdall @drohit-cb @marcin-cb @yuga-cb @John-peterson-coinbase