Skip to content

Conversation

@drohit-cb
Copy link
Contributor

@drohit-cb drohit-cb commented Aug 1, 2024

What changed? Why?

This PR helps document the available options while creating/building a staking operation.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 1, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb changed the base branch from master to v0.0.14 August 1, 2024 17:53
@drohit-cb drohit-cb marked this pull request as ready for review August 1, 2024 17:59
@drohit-cb drohit-cb force-pushed the document_staking_options branch from aeded4a to 78f120a Compare August 1, 2024 18:10
@drohit-cb drohit-cb force-pushed the document_staking_options branch 2 times, most recently from aacad56 to f3eaa97 Compare August 2, 2024 22:43
@drohit-cb drohit-cb requested a review from marcin-cb August 2, 2024 22:43
@drohit-cb drohit-cb force-pushed the document_staking_options branch from f3eaa97 to 76368a3 Compare August 5, 2024 20:25
Base automatically changed from v0.0.14 to master August 5, 2024 22:35
@cb-heimdall
Copy link

Review Error for melissamforbs @ 2024-08-18 06:19:06 UTC
User must have write permissions to review

@marcin-cb marcin-cb self-requested a review August 18, 2024 18:06
marcin-cb
marcin-cb previously approved these changes Aug 18, 2024
@drohit-cb drohit-cb changed the base branch from master to v0.2.0 August 26, 2024 19:11
@drohit-cb drohit-cb force-pushed the document_staking_options branch from 76368a3 to efa9a5c Compare August 26, 2024 19:27
@cb-heimdall cb-heimdall dismissed marcin-cb’s stale review August 26, 2024 19:27

Approved review 2244373091 from marcin-cb is now dismissed due to new commit. Re-request for approval.

@drohit-cb drohit-cb force-pushed the document_staking_options branch 7 times, most recently from 20b5c77 to 7bd30eb Compare August 26, 2024 22:52
@drohit-cb drohit-cb requested a review from marcin-cb August 27, 2024 15:40
@drohit-cb drohit-cb force-pushed the document_staking_options branch from 7bd30eb to 7401a6a Compare August 27, 2024 15:47
@drohit-cb drohit-cb merged commit cda10fc into v0.2.0 Aug 27, 2024
@drohit-cb drohit-cb deleted the document_staking_options branch August 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants