Adding retry for failed GET requests #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
commented
Jul 22, 2024
src/coinbase/coinbase.ts
Outdated
| retryCondition: (error: AxiosError) => { | ||
| return ( | ||
| error.config?.method?.toUpperCase() === "GET" && | ||
| (error.response?.status || 0) in [500, 501, 502, 503, 504] |
Contributor
Author
There was a problem hiding this comment.
we can add more if we need
Contributor
There was a problem hiding this comment.
501 not implemented seems like not worth retrying?
500 feels borderline, since that would indicate that our service is explicitly throwing that error. However it's likely that there are a number of retryable errors that bubble up to a 500 that we need to squash first.
I think it's fine to leave 500 for now, but I would probably drop 501 from this list.
erdimaden
changed the title
erdimaden
changed the title
erdimaden
changed the title
erdimaden
force-pushed
the
feat/network-retry
branch
from
d7e3f1b to
f5c01ed
Compare
✅ Heimdall Review Status
|
alex-stone
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adding auto-retry functionality for failed GET requests
Qualified Impact