Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.3 #61

Merged
merged 2 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## [1.4.3] - 2024-JUL-22

### Added
- - `order_ids`, `time_in_forces` and `sort_by` parameters in List Orders
- `trade_ids` and `sort_by` in List Fills

### Changed
- `skip_fcm_risk_check` parameter removed from various Orders methods.
- `product_id` and `order_type` has been replaced by `product_ids` and `order_types` in List Orders
- `order_id` and `product_id` has been replaced by `order_ids` and `product_ids` in List Fills

## [1.4.2] - 2024-JUN-17

### Added
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pip3 install coinbase-advanced-py
___
## Coinbase Developer Platform (CDP) API Keys

This SDK uses Cloud Developer Platform (CDP) API keys. To use this SDK, you will need to create a CDP API key and secret by following the instructions [here](https://docs.cdp.coinbase.com/advanced-trade/docs/auth).
This SDK uses Cloud Developer Platform (CDP) API keys. To use this SDK, you will need to create a CDP API key and secret by following the instructions [here](https://docs.cdp.coinbase.com/advanced-trade/docs/getting-started).
Make sure to save your API key and secret in a safe place. You will not be able to retrieve your secret again.

WARNING: We do not recommend that you save your API secrets directly in your code outside of testing purposes. Best practice is to use a secrets manager and access your secrets that way. You should be careful about exposing your secrets publicly if posting code that leverages this library.
Expand Down
2 changes: 1 addition & 1 deletion coinbase/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.4.2"
__version__ = "1.4.3"
2 changes: 2 additions & 0 deletions coinbase/rest/fees.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def get_transaction_summary(
self,
product_type: Optional[str] = None,
contract_expiry_type: Optional[str] = None,
product_venue: Optional[str] = None,
**kwargs,
) -> Dict[str, Any]:
"""
Expand All @@ -30,6 +31,7 @@ def get_transaction_summary(
params = {
"product_type": product_type,
"contract_expiry_type": contract_expiry_type,
"product_venue": product_venue,
}

return self.get(endpoint, params=params, **kwargs)
Loading
Loading