Fix OOM when decoding large PNGs on API 23 and below. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Fix OOM when decoding large PNGs on API 23 and below. * Rename file. * Temporarily disable fail-fast. * Update tests. * Upload larger HEIF file. * Add large JPG test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #368.
This fixes the OOM on API 23 and below. The crash was due to a difference in how
BufferedInputStreamincreases its buffer size on Java 7 vs. Java 8.We could fix this issue by making
ExifInterfaceInputStream.availablereturn a smaller value, however I decided to avoid EXIF data parsing entirely for PNG files. This is because EXIF data is very rarely used (especially for orientation) in PNGs and it would slow down every other PNG that doesn't have EXIF data as the decode can't short circuit when it finds the EXIF chunk.