Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate network call for chunked responses #2363

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix duplicate network call for chunked responses #2363

merged 2 commits into from
Jul 10, 2024

Conversation

ferinagy
Copy link

@ferinagy ferinagy commented Jul 9, 2024

Fixes #1543

colinrtwhite
colinrtwhite approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@colinrtwhite colinrtwhite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I'll include this in the 2.7.0 release, which should go out soon.

coil-base/src/main/java/coil/fetch/HttpUriFetcher.kt Outdated Show resolved Hide resolved
@ferinagy @colinrtwhite
Avoid allocating a new peek source
cb4822c 
Co-authored-by: Colin White <colin@colinwhite.me>
@colinrtwhite colinrtwhite merged commit 9135616 into coil-kt:2.x Jul 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinrtwhite colinrtwhite colinrtwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferinagy @colinrtwhite