Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters #1839

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters #1839

merged 3 commits into from
Aug 10, 2023

Conversation

fingertricks
Copy link
Contributor

Fixes #1838

Dave Jones added 2 commits August 8, 2023 12:39
Add failing test for coil-kt#1838
ce713ff
Fixes loading from disk cache when cached headers contain non-ASCII c…
fb0f3d1 
…haracters coil-kt#1838

Allows disk cache headers to be updated after a 304 Not Modified, as detailed in coil-kt#1838
@fingertricks fingertricks mentioned this pull request Aug 8, 2023
Closed
colinrtwhite
colinrtwhite approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@colinrtwhite colinrtwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix and regression test!

@colinrtwhite colinrtwhite merged commit 82e1171 into coil-kt:main Aug 10, 2023
7 checks passed
colinrtwhite added a commit that referenced this pull request Aug 10, 2023
@colinrtwhite
Merge branch 'main' into 3.x
541aa9a 
* main:
  Bump androidx.benchmark:benchmark-macro-junit4 (#1841)
  Bump androidx.compose.ui:ui-test-junit4 from 1.4.3 to 1.5.0 (#1842)
  Bump compose from 1.4.3 to 1.5.0 (#1840)
  Disk cache load fails after 304 Not Modified when cached headers include non-ASCII characters (#1839)
  Remove the Okio Proguard rule. (#1837)
  Bump okio from 3.4.0 to 3.5.0 (#1836)
  Bump androidx.recyclerview:recyclerview from 1.3.0 to 1.3.1 (#1832)
  Bump androidx.benchmark:benchmark-macro-junit4 (#1831)
  Fix coil-benchmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinrtwhite colinrtwhite colinrtwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disk cached image with non-ASCII headers can't be updated after 304 Not Modified
2 participants
@fingertricks @colinrtwhite