Enable jvm-default=all. #1491
Merged
Enable jvm-default=all. #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
added a commit
that referenced
this pull request
Oct 22, 2022
* Enable jvm-default=all. * Revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is finally safe to enable as of Kotlin
1.6.20as the downstream warning for consumers was removed. The change should be transparent to users as the change is binary compatible (we need to mark existing interfaces with@JvmDefaultWithCompatibilitythough), source compatible, and doesn't require adding a compiler argument. Jetpack Compose made this change in1.2.0.This change also makes it easier to implement
ListenerandTargetin Java.