-
Notifications
You must be signed in to change notification settings - Fork 4
[CDF-24214] 👮Standardize Transformation Authentication #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doctrino
wants to merge
9
commits into
main
Choose a base branch
from
transformation-without-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3f7c873
to
8a4067c
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Learning that the
sourceOidcCredentials
anddestinationOidcCredentials
are deprecated, introducing the same setup as workflows and functions for providing clientId/clientSecret to give auth.Changelog
cdf
Improved
FunctionSchedules
andWorkflowTrigger
. That is allow you to only specifyclientId/clientSecret
if you are doing a transformation within the same CDF Project as the Toolkit is configured for.sourceOidcCredentials
anddestinationOidcCredentials
.Removed
sourceNonce
anddestinationNonce
directly in a Transformation. You need to useauthentication.clientId
/authentication.ClientSecret
instead.templates
No changes.