Skip to content

[CDF-24214] 👮Standardize Transformation Authentication #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 22, 2025
Merged

[CDF-24214] 👮Standardize Transformation Authentication #1565

merged 18 commits into from
May 22, 2025

Conversation

@doctrino
Copy link
Collaborator

@doctrino doctrino commented May 13, 2025 •
edited
Loading

Description

Learning that the sourceOidcCredentials and destinationOidcCredentials are deprecated, introducing the same setup as workflows and functions for providing clientId/clientSecret to give auth.

Changelog

  • Patch
  • Minor
  • Skip

cdf

Improved

  • Standardization of authentication for Transformations, i.e., matching FunctionSchedules and WorkflowTrigger. That is allow you to only specify clientId/clientSecret if you are doing a transformation within the same CDF Project as the Toolkit is configured for.
  • Warning message if you set sourceOidcCredentials and destinationOidcCredentials.

Removed

  • You can no longer set sourceNonce and destinationNonce directly in a Transformation. You need to use authentication.clientId/authentication.ClientSecret instead.

templates

No changes.

@doctrino doctrino mentioned this pull request May 13, 2025
Closed
3 tasks
@doctrino doctrino requested a review from ronpal May 22, 2025 10:26
@doctrino doctrino requested a review from dmivankov May 22, 2025 10:26
ronpal
ronpal previously approved these changes May 22, 2025
View reviewed changes
@dmivankov
Copy link
Contributor

risk review ok

@dmivankov
Copy link
Contributor

now there's merge conflicts though

@doctrino
Merge remote-tracking branch 'origin/main' into transformation-withou…
60d6ee1 
…t-scope

# Conflicts:
#	cognite_toolkit/_cdf_tk/utils/cdf.py
@dmivankov
Copy link
Contributor

🦄

@doctrino doctrino requested a review from ronpal May 22, 2025 12:30
@doctrino doctrino merged commit 55c2758 into main May 22, 2025
15 checks passed
@doctrino doctrino deleted the transformation-without-scope branch May 22, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronpal ronpal ronpal approved these changes

@dmivankov dmivankov Awaiting requested review from dmivankov

Assignees

@dmivankov dmivankov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@doctrino @dmivankov @ronpal