Content fixes: ctrl+click for new tab, and fix the history #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… = open new tab in browser. need to add tabs structure for non-web to support there too. for #1644
… need to debug more. also need to store URL somewhere.
…tabs methods can be called in the update -- fixes deadlock in content.
…on and delete history record.
… functionality working. just need updating -- very easy overall.
…sed search (next).
…b version now working again.
Member
Author
|
@kkoreilly this is ready for review. The fail is just an image that needs updated -- will do that after merge -- verified on an earlier one here. I'll give you just a couple of days and will otherwise merge myself, and you can make suggestions or corrections later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1548 #1644 #28 #1111 and mostly addresses #1325
This fixes the main remaining missing features for content, and search is very long overdue.