Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce env variable DISABLE_RATE_LIMIT to disable rate limit #98

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

schmidp
Copy link
Contributor

@schmidp schmidp commented Mar 31, 2023

We locally run into rate limiting. since we don't want to specify a rate limiting within the company at all, especially because some NAT clients use the same IP, we introduced this variable with minimal changes.

@Frajder
Copy link
Contributor

Frajder commented Apr 1, 2023

I ran into a similar problem, so I just increased the limit. I don't think it's a good idea to completely disable the limit because there is a good reason for having it. My suggestion would be to make this ENV variable represent the number of requests allowed in 15 minutes, with 0 representing unlimited requests as if we had set this DISABLE_RATE_LIMIT variable to true. If this variable is not specified, the default would be 100 as it is now. This would allow for more flexibility, in my opinion.

@schmidp
Copy link
Contributor Author

schmidp commented Apr 5, 2023

@Frajder you are of course right, I was just lazy :)

Better now?

@Frajder
Copy link
Contributor

Frajder commented Apr 5, 2023

Yes it's better, thank you!

@cogentapps cogentapps merged commit 019cd42 into cogentapps:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants