Project Reorganization #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
6 times, most recently
from
b29d99d
to
264a1ec
Compare
solomon-b
force-pushed
the
feature/xdg-config-files
branch
from
e5b0a4d
to
8dc4c00
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
4 times, most recently
from
79795ce
to
310a0dd
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
11 times, most recently
from
57952d3
to
dcb5507
Compare
masaeedu
reviewed
Dec 19, 2022
chat-bots/src/Data/Chat/Bot.hs
Outdated
| @@ -50,8 +47,6 @@ import System.FilePath | |||
|
|
|||
| -------------------------------------------------------------------------------- | |||
|
|
|||
| type KBot = (Type -> Type) -> Type -> Type -> Type -> Type | |||
There was a problem hiding this comment.
Sorry to be a stickler, but is it possible to redo this PR keeping any changes of this sort out of it?
|
I think this is good, provided we can ensure nothing else is happening in this PR besides creating three new cabal components and distributing the existing modules amongst them. If anything besides that is happening, can we please separate that out into another PR? |
solomon-b
force-pushed
the
feature/xdg-config-files
branch
2 times, most recently
from
bb3bf17
to
afb9579
Compare
solomon-b
force-pushed
the
feature/xdg-config-files
branch
2 times, most recently
from
695f54f
to
d65130e
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
2 times, most recently
from
241261b
to
93a0385
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
from
93a0385
to
aa35dfa
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
5 times, most recently
from
126303f
to
d329cb5
Compare
solomon-b
force-pushed
the
feature/breakup-bot-module
branch
from
d329cb5
to
12d1aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN PROGRESS
Breaks up the file into 3 cabal projects:
Breaking up the project like this means reduced dependencies in the core chat bot library when we post it to Hackage.