Correct bug in unique #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some godawful reason
```
console.log(JSON.stringify(value) + " => " + JSON.stringify(value)) for key, value of {}
```
logs
```
undefined => undefined
```
So we must ensure we only return properties owned by the output object, so that null doesn't get added to our array of unique elements. This issue may be specific to my setup (Latest version of Chrome, running on a Windows VM in close proximity to an Indian burial ground), but I believe this change still improves the clarity of the example.
|
I can't repro on 36.0.1952.0 (Official Build 265233) canary 34.0.1847.116 (Official Build 260972) (for key, value of {} never enters the loop). Can you link a jsfiddle with your compiled coffeescript in case there are differences? |
|
I'm away from my machine right now, I'll put a jsfiddle together tomorrow to demonstrate this. (Or update you on how exactly I shot myself in the foot & caused this to happen. Either way.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where [].unique() evaluated to [null].
For some godawful reason
logs
So we must ensure we only return properties owned by the output object, so that null doesn't get added to our array of unique elements. This issue may be specific to my setup (Latest version of Chrome, running on a Windows VM in close proximity to an Indian burial ground), but I believe this change still improves the clarity and correctness of the example.