Fix journal-reader example to point to the most recent entry #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a random one. If next if called directly after seek tail, a random old entry is pointed. See the implementation in journalctl: https://github.com/systemd/systemd/blob/8389fd19d20370077f2d5601af0a089ec92ece05/src/journal/journalctl.c#L1292-L1299 And this related bug report: https://bugs.freedesktop.org/show_bug.cgi?id=64614
codyps
approved these changes
Dec 9, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2021
234: Fix journal-reader example to point to the most recent entry r=jmesmon a=romainreignier If next if called directly after seek tail, a random old entry is pointed. See the implementation in journalctl: https://github.com/systemd/systemd/blob/8389fd19d20370077f2d5601af0a089ec92ece05/src/journal/journalctl.c#L1292-L1299 And this related bug report: https://bugs.freedesktop.org/show_bug.cgi?id=64614 Co-authored-by: Romain Reignier <rre@robopec.com>
|
Build failed: |
Merged
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 10, 2021
234: Fix journal-reader example to point to the most recent entry r=jmesmon a=romainreignier If next if called directly after seek tail, a random old entry is pointed. See the implementation in journalctl: https://github.com/systemd/systemd/blob/8389fd19d20370077f2d5601af0a089ec92ece05/src/journal/journalctl.c#L1292-L1299 And this related bug report: https://bugs.freedesktop.org/show_bug.cgi?id=64614 236: fix build on docs.rs r=jmesmon a=jmesmon Co-authored-by: Romain Reignier <rre@robopec.com> Co-authored-by: Cody P Schafer <dev@codyps.com>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If next if called directly after seek tail, a random old entry is pointed.
See the implementation in journalctl:
https://github.com/systemd/systemd/blob/8389fd19d20370077f2d5601af0a089ec92ece05/src/journal/journalctl.c#L1292-L1299
And this related bug report: https://bugs.freedesktop.org/show_bug.cgi?id=64614