Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use the new public karma api for refreshing files #63

Merged
merged 1 commit into from
Jul 31, 2015

Conversation

dignifiedquire
Copy link
Collaborator

I've just released 0.13.2 which adds a public api, that avoids having the breakage that was experienced with the upgrade to 0.13.0

Closes #62, karma-runner/karma#1497

@alexilyaev
Copy link

Eagerly waiting for this fix.

@MikaAK
Copy link
Contributor

MikaAK commented Jul 20, 2015

Nice job on the fix, I was giving this a try and for some reason webpack just hangs indefinitely now. It just sits at 115/124 forever 😢
screen shot 2015-07-20 at 11 11 00 am

@dignifiedquire
Copy link
Collaborator Author

@MikaAK it was running fine on my examples, any chance you could share the code/ a minimal repro for the hanging behaviour?

@MikaAK
Copy link
Contributor

MikaAK commented Jul 20, 2015

I've extracted on of our projects out to here It's not the most minimal unfortunately but I've tried to take it down a bit. While I was doing so I deleted some of my view_models folders and it caused this to start working again and not stall. I'll try to dig a bit deeper as well

Update @dignifiedquire I managed to find what causes it to stall, but I have no idea why it causes it to do so. I've left some notes in the readme.

@hekike
Copy link

hekike commented Jul 21, 2015

I checked @dignifiedquire 's fork and it's working great for me with Karma 0.13.2. Great work!

nkbt added a commit to nkbt/react-component-template that referenced this pull request Jul 24, 2015
@PatrickJS
Copy link

works for me

"karma-webpack": "Dignifiedquire/karma-webpack#29fb1d801158f29cb0eb784edff69356705a7b74",

@nkbt
Copy link

nkbt commented Jul 27, 2015

@sokra any chance to get this merged in soon? Thanks!

@iam4x
Copy link

iam4x commented Jul 29, 2015

Let's 🚢 this please!

@PatrickJS
Copy link

@gabel
Copy link

gabel commented Jul 30, 2015

:shipit:

sokra added a commit that referenced this pull request Jul 31, 2015
Upgrade to use the new public karma api for refreshing files
@sokra sokra merged commit 5760256 into codymikol:master Jul 31, 2015
@sokra
Copy link
Contributor

sokra commented Jul 31, 2015

Thanks

@sokra
Copy link
Contributor

sokra commented Jul 31, 2015

@dignifiedquire Do you want to maintain this module?

@hekike
Copy link

hekike commented Jul 31, 2015

@sokra when do you plan to release this?

@dignifiedquire
Copy link
Collaborator Author

@sokra I'm happy to help out sure.

@nkbt
Copy link

nkbt commented Jul 31, 2015 via email

@sokra
Copy link
Contributor

sokra commented Jul 31, 2015

published

@tupy
Copy link

tupy commented Jul 31, 2015

💯

@hekike
Copy link

hekike commented Jul 31, 2015

@sokra yepp, thanks! Working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants